penkovsky_sa/cherrypick
1
0
Fork 0
mirror of https://github.com/pese-git/cherrypick.git synced 2026-01-24 05:25:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: update instance generator code

Browse Source
This commit is contained in:
Sergey Penkovsky
2025-05-23 08:06:08 +03:00
parent 6d5537f068
commit 46c2939125
1 changed files with 14 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
cherrypick_generator/lib/src/bind_spec.dart
View File

@@ -125,9 +125,11 @@ class BindSpec {
final multiLine = fnArgs.length > 60 || fnArgs.contains('\n'); final multiLine = fnArgs.length > 60 || fnArgs.contains('\n');
switch (bindingType) { switch (bindingType) {
case BindingType.instance: case BindingType.instance:
return isAsyncInstance throw StateError(
? '.toInstanceAsync(($fnArgs) => $methodName($fnArgs))' 'Internal error: _generateWithParamsProvideClause called for @instance binding with @params.');
: '.toInstance(($fnArgs) => $methodName($fnArgs))'; //return isAsyncInstance
// ? '.toInstanceAsync(($fnArgs) => $methodName($fnArgs))'
// : '.toInstance(($fnArgs) => $methodName($fnArgs))';
case BindingType.provide: case BindingType.provide:
default: default:
if (isAsyncProvide) { if (isAsyncProvide) {
@@ -218,6 +220,15 @@ class BindSpec {
final bindingType = final bindingType =
hasInstance ? BindingType.instance : BindingType.provide; hasInstance ? BindingType.instance : BindingType.provide;
// PROHIBIT @params with @instance bindings!
if (bindingType == BindingType.instance && hasParams) {
throw InvalidGenerationSourceError(
'@params() (runtime arguments) cannot be used together with @instance() on method $methodName. '
'Use @provide() instead if you want runtime arguments.',
element: method,
);
}
// -- Extract inner type for Future<T> and set async flags. // -- Extract inner type for Future<T> and set async flags.
bool isAsyncInstance = false; bool isAsyncInstance = false;
bool isAsyncProvide = false; bool isAsyncProvide = false;