Resolved all Dart analyzer warnings across multiple files

benchmark_cherrypick/analysis_options.yaml

@@ -0,0 +1,33 @@
+# This file configures the static analysis results for your project (errors,
+# warnings, and lints).
+#
+# This enables the 'recommended' set of lints from `package:lints`.
+# This set helps identify many issues that may lead to problems when running
+# or consuming Dart code, and enforces writing Dart using a single, idiomatic
+# style and format.
+#
+# If you want a smaller set of lints you can change this to specify
+# 'package:lints/core.yaml'. These are just the most critical lints
+# (the recommended set includes the core lints).
+# The core lints are also what is used by pub.dev for scoring packages.
+
+include: package:lints/recommended.yaml
+analyzer:
+  errors:
+    deprecated_member_use: ignore
+
+# Uncomment the following section to specify additional rules.
+
+# linter:
+#   rules:
+#     - camel_case_types
+
+# analyzer:
+#   exclude:
+#     - path/to/excluded/files/**
+
+# For more information about the core and recommended set of lints, see
+# https://dart.dev/go/core-lints
+
+# For additional information about configuring this file, see
+# https://dart.dev/guides/language/analysis-options

benchmark_cherrypick/bin/main.dart

@@ -1,4 +1,3 @@
-import 'package:benchmark_runner/benchmark_runner.dart';
 import 'package:benchmark_cherrypick/cherrypick_benchmark.dart';
 import 'package:benchmark_cherrypick/complex_bindings_benchmark.dart';
 import 'package:benchmark_cherrypick/async_chain_benchmark.dart';

benchmark_cherrypick/lib/async_chain_benchmark.dart

@@ -1,3 +1,4 @@
+// ignore: depend_on_referenced_packages
 import 'package:benchmark_harness/benchmark_harness.dart';
 import 'package:cherrypick/cherrypick.dart';
 

benchmark_cherrypick/lib/cherrypick_benchmark.dart

@@ -1,3 +1,4 @@
+// ignore: depend_on_referenced_packages
 import 'package:benchmark_harness/benchmark_harness.dart';
 import 'package:cherrypick/cherrypick.dart';
 

benchmark_cherrypick/lib/complex_bindings_benchmark.dart

@@ -1,3 +1,4 @@
+// ignore: depend_on_referenced_packages
 import 'package:benchmark_harness/benchmark_harness.dart';
 import 'package:cherrypick/cherrypick.dart';
 

benchmark_cherrypick/lib/scope_override_benchmark.dart

@@ -1,3 +1,4 @@
+// ignore: depend_on_referenced_packages
 import 'package:benchmark_harness/benchmark_harness.dart';
 import 'package:cherrypick/cherrypick.dart';
 

benchmark_cherrypick/pubspec.lock

@@ -48,6 +48,14 @@ packages:
       url: "https://pub.dev"
     source: hosted
     version: "0.2.3"
+  lints:
+    dependency: "direct dev"
+    description:
+      name: lints
+      sha256: c35bb79562d980e9a453fc715854e1ed39e24e7d0297a880ef54e17f9874a9d7
+      url: "https://pub.dev"
+    source: hosted
+    version: "5.1.1"
   meta:
     dependency: transitive
     description:
@@ -57,4 +65,4 @@ packages:
     source: hosted
     version: "1.17.0"
 sdks:
-  dart: ">=3.5.0 <4.0.0"
+  dart: ">=3.6.0 <4.0.0"

benchmark_cherrypick/pubspec.yaml

@@ -11,5 +11,6 @@ dependencies:
     path: ../cherrypick
 
 dev_dependencies:
+  lints: ^5.0.0
   benchmark_harness: ^2.2.2
   benchmark_runner: ^0.0.2